Fix GCS google_application_credentials raw value in model regression #8372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovincyrus
force-pushed
the
cyrus/gcs-model-regression-fix
branch
from
47e29cb to
c85a62e
Compare
royendo
approved these changes
Nov 20, 2025
Contributor
royendo
left a comment
royendo
left a comment
There was a problem hiding this comment.
UX pass good, adding EricG for code review (seems he's back soon based on Slack)
ericpgreen2
approved these changes
Nov 20, 2025
Contributor
There was a problem hiding this comment.
I'll approve so we can cherry-pick this ASAP, but we need to add tests for critical bugs like this that make it to production. Here's a Linear ticket.
lovincyrus
added a commit
that referenced
this pull request
Nov 21, 2025
…8372) * inital * strip connector values when transitioning to the model form * wip * exclude connector config in prepareSourceFormData to avoid secret leakage * revert * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR strips the connector config from model YAML in multi-step flow (prevent GCS creds leak).
Root cause: Connector step values (e.g., google_application_credentials) were carried into the model step and used for model YAML generation; preview filtered them, but submission did not.
Closes https://linear.app/rilldata/issue/APP-587/regression-model-includes-plaintext-credentials-introduced-in-8142
Checklist: