Skip to content

fix: filter out time dimension from categorical for canvas #8380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djbarnwal merged 5 commits into from
Nov 27, 2025
Merged

fix: filter out time dimension from categorical for canvas #8380

djbarnwal merged 5 commits into from
Nov 27, 2025

Conversation

@djbarnwal
Copy link
Member

@djbarnwal djbarnwal commented Nov 23, 2025 •
edited
Loading

Some canvas input elements use the dimensions list from the metrics view. With the recent changes, time dimension is also added to the dimensions list.

This PR filters out the and only preserves the categorical dimensions.

Before
image

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!
@djbarnwal djbarnwal merged commit c0a3dab into main Nov 27, 2025
15 of 18 checks passed
@djbarnwal djbarnwal deleted the fix/filter-time-dimension branch November 27, 2025 10:15
djbarnwal added a commit that referenced this pull request Nov 27, 2025
@djbarnwal
fix: filter out time dimension from categorical for canvas (#8380)
dea9850 
* add field details, remove __time hardcoding

* fix: filter out time dimension from categorical

* filter time dimension from leaderboard and pivot
mindspank added a commit that referenced this pull request Dec 4, 2025
@mindspank
Revert "fix: filter out time dimension from categorical for canvas (#…
35662e2 
…8380)"

This reverts commit dea9850.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@djbarnwal @AdityaHegde