Fix Save Anyway e2e #8389
Merged
Fix Save Anyway e2e #8389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Nov 24, 2025
Comment on lines
38
to
44
| await expect(page).toHaveURL(/.*\/files\/connectors\/.*\.yaml/, { | ||
| timeout: 60000, | ||
| }); | ||
| const codeEditor = page | ||
| .getByLabel("codemirror editor") | ||
| .getByRole("textbox"); | ||
| await expect(codeEditor).toBeVisible({ timeout: 45000 }); | ||
| await expect(page).toHaveURL(/.*\/files\/connectors\/.*\.yaml/, { | ||
| timeout: 45000, | ||
| }); | ||
| await expect(codeEditor).toBeVisible({ timeout: 60000 }); |
Contributor
There was a problem hiding this comment.
We need to lower these timeouts from 60s. In the success case, it shouldn't take 60s for these elements to appear. In the failure case, this'll really lengthen the test time. How about 3-5 seconds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a green light from another PR with the same changeset d3a10e0
Checklist: