Skip to content

feat: navigation event #8397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mindspank merged 4 commits into from
Nov 30, 2025
Merged

feat: navigation event #8397

mindspank merged 4 commits into from
Nov 30, 2025

Conversation

@mindspank
Copy link
Contributor

@mindspank mindspank commented Nov 26, 2025 •
edited
Loading

Adds a navigation event to the iframe api.
Closes APP-609

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!
AdityaHegde
AdityaHegde approved these changes Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some assertion in navigation embed tests?
@mindspank mindspank merged commit 8b997c6 into main Nov 30, 2025
10 checks passed
@mindspank mindspank deleted the feat/navigation-event branch November 30, 2025 21:39
mindspank added a commit that referenced this pull request Nov 30, 2025
@mindspank
feat: navigation event (#8397)
ad32e4d 
* feat: navigation event

* review

* pretty

* add some timeouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@mindspank @AdityaHegde