-
Notifications
You must be signed in to change notification settings - Fork 159
feat (AI): Introduce a Developer Chat behind a feature flag #8409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5710f15 to
81e3d11
Compare
76f5b6e to
dd8d559
Compare
|
Is this ready to test? |
Code ReviewDeveloped in collaboration with Claude Code and Eric. OverviewThis PR introduces a Developer Chat feature behind a Must Fix1. ChatConfig location The config lives in Consider Fixing2. Type assertions Replace angle-bracket assertions with // Before
return <RuntimeServiceCompleteBody>{
analystAgentContext,
};
// After
return {
analystAgentContext,
} satisfies Partial<RuntimeServiceCompleteBody>;The angle-bracket syntax ( Tech Debt / Future Work3. ConversationManager agent-keying and conversation filtering The Once Platform provides a surface filtering scheme, the preferred approach is:
The 4. Context directory coupling (agent-contexts.ts) The chat feature reaches into dashboard internals ( A cleaner pattern would be for each feature to export its own context for chat:
5. ChatConfig eager store creation The config objects are defined at module scope: export const dashboardChatConfig = <ChatConfig>{
additionalContextStore: getActiveExploreContext(), // Called at import time
...
};This creates derived stores even when chat isn't being used. Consider lazy initialization via a factory function. |
ericpgreen2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving w/ comments to unblock the release, though I note that there's tech debt to clean up.
|
Thanks @ericpgreen2 . I have addressed your comments except |
* feat: generate sample data CTA * Add a button in add asset dropdown * First version of developer chat * Make AI chat work on main page * More UI changes to pass in context of current page the user is viewing * Cleanup * Bug fixes * Misc changes * Remove generate data specific code * PR comments * Fix tests --------- Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com>
Feature flag:
developerChatChecklist: