Skip to content

check time dim error before checking smallest time grain #8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pjain1 merged 2 commits into from
Dec 1, 2025
Merged

check time dim error before checking smallest time grain #8422

pjain1 merged 2 commits into from
Dec 1, 2025

Conversation

@pjain1
Copy link
Member

@pjain1 pjain1 commented Dec 1, 2025

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!
@pjain1 pjain1 requested a review from begelundmuller December 1, 2025 15:32
begelundmuller
begelundmuller approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@pjain1 pjain1 merged commit bf461a0 into main Dec 1, 2025
14 of 15 checks passed
@pjain1 pjain1 deleted the check_time_dim_err branch December 1, 2025 16:02
pjain1 added a commit that referenced this pull request Dec 1, 2025
@pjain1
check time dim error before checking smallest time grain (#8422)
b6a46a6 
* check time dim error before checking smallest time grain

* safe check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@pjain1 @begelundmuller