Skip to content

feat (AI): Add tab for MCP OAuth instructions #8426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericpgreen2 merged 7 commits into from
Dec 2, 2025
Merged

feat (AI): Add tab for MCP OAuth instructions #8426

ericpgreen2 merged 7 commits into from
Dec 2, 2025

Conversation

@ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Dec 1, 2025 •
edited
Loading

Closes APP-578

Tab 1:
image

Tab 2:
image

Two notes on our design system:

  1. When clicking the Oauth's "copy" button, a toast notification appears ("Copied X URL"). Prior to the changes in this PR, the toast notification appeared behind the dialog's overlay. To fix that, this PR increases the z-index of the Notification component.
  2. When switching between the dialog's tabs, the dialog height changes. This led to a bug in the dialog's unmount flyAndScale animation. This PR changes the animation to fade, which does not have the same visual glitch. This PR changes the animation for all dialogs, for design consistency.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!
@ericpgreen2 ericpgreen2 self-assigned this Dec 1, 2025
@ericpgreen2 ericpgreen2 added the blocker A release blocker issue that should be resolved before a new release label Dec 1, 2025
@ericpgreen2 ericpgreen2 marked this pull request as ready for review December 1, 2025 22:33
pjain1
pjain1 approved these changes Dec 2, 2025
View reviewed changes
Copy link
Member

@pjain1 pjain1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from product POV. Just FYI that OAuth does not work with http scheme works only with https, not an issue here since it will always be for deployed projects.
AdityaHegde
AdityaHegde approved these changes Dec 2, 2025
View reviewed changes
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a couple of nits
@ericpgreen2 ericpgreen2 merged commit c936be8 into main Dec 2, 2025
23 checks passed
@ericpgreen2 ericpgreen2 deleted the mcp-oauth-instructions branch December 2, 2025 14:29
ericpgreen2 added a commit that referenced this pull request Dec 2, 2025
@ericpgreen2
feat (AI): Add tab for MCP OAuth instructions (#8426)
195efda 
* feat (AI): Add tab for MCP Oauth instructions

* Use existing `Tag` component

* Create component for underlined tabs

* Fix dialog animation bug

* Fix notification z-index

* Remove custom styles on `<a>` element

* Fix `CMD` key triggering notification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocker A release blocker issue that should be resolved before a new release

4 participants

@ericpgreen2 @AdityaHegde @pjain1