fix: org user management page sending too many requests #8427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
approved these changes
Dec 2, 2025
ericpgreen2
approved these changes
Dec 3, 2025
Contributor
ericpgreen2
left a comment
ericpgreen2
left a comment
There was a problem hiding this comment.
Looks good! Nice optimization to defer the per-row API requests to dropdown open.
Minor: The pluralization groupCount > 1 ? "s" : "" at UserGroupsCell.svelte:34 shows "0 Group" and "1 Group". Consider groupCount !== 1 ? "s" : "" for correct English pluralization ("0 Groups", "1 Group", "2 Groups"). Same applies to UserProjectsCell.svelte:44.
Developed in collaboration with Claude Code and Eric.
AdityaHegde
added a commit
that referenced
this pull request
Dec 3, 2025
* fix: org user management page sending too many requests * Update tests * Fix pluralization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are making a call per row for group and project count. This moves the request to the dropdown only when it is open. Instead it uses the count from
ListOrganizationMemberUsersChecklist: