Let dimensions with type DATE default to CATEGORICAL type unless used as the default time dimension
#8439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used as the default time dimension
pjain1
reviewed
Dec 4, 2025
| case runtimev1.Type_CODE_TIMESTAMP, runtimev1.Type_CODE_DATE, runtimev1.Type_CODE_TIME: | ||
|
|
||
| // Infer the dimension type | ||
| switch code { |
Member
There was a problem hiding this comment.
if !ok from typ, ok := types[d.Name] on line 687, then this will nil? Does it work with switch fine?
pjain1
approved these changes
Dec 4, 2025
mindspank
deleted the
begelundmuller/date-default-categorical-if-not-default-time-dim
branch
mindspank
pushed a commit
that referenced
this pull request
Dec 4, 2025
…used as the default time dimension (#8439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.