Skip to content

fix: implicit connectors not detected for secret sql generation #8452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NamanMahor merged 4 commits into from
Dec 5, 2025
Merged

fix: implicit connectors not detected for secret sql generation #8452

NamanMahor merged 4 commits into from
Dec 5, 2025

Conversation

@k-anshul
Copy link
Member

@k-anshul k-anshul commented Dec 5, 2025 •
edited
Loading

INSERT DESCRIPTION HERE

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!
@k-anshul k-anshul self-assigned this Dec 5, 2025
@k-anshul k-anshul requested a review from NamanMahor December 5, 2025 06:45
NamanMahor
NamanMahor reviewed Dec 5, 2025
View reviewed changes
runtime/drivers/registry.go
Type: "azure",
Name: "azure",
})
case "google_application_credentials":
Copy link
Contributor

@NamanMahor NamanMahor Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcs not required because not supported by secrets.
Copy link
Member Author

@k-anshul k-anshul Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can keep from completion POV.
We add it in auto detection :

// If no connectors are configured, automatically detect all connectors of type s3, azure, gcs, or https from the project.
NamanMahor
NamanMahor reviewed Dec 5, 2025
View reviewed changes
NamanMahor
NamanMahor reviewed Dec 5, 2025
View reviewed changes
@NamanMahor NamanMahor merged commit d7634a6 into main Dec 5, 2025
9 of 10 checks passed
@NamanMahor NamanMahor deleted the implicit_envs branch December 5, 2025 07:17
NamanMahor pushed a commit that referenced this pull request Dec 5, 2025
@k-anshul @NamanMahor
fix: implicit connectors not detected for secret sql generation (#8452)
1845df0 
* fix: implicit connectors not detected for secret sql generation

* fix: implicit connectors not detected for secret sql generation

* fix: implicit connectors not detected for secret sql generation

* dedupe connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@k-anshul @NamanMahor