Skip to content

fix: contains filter not applying to dimension table #8457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AdityaHegde merged 2 commits into from
Dec 9, 2025
Merged

fix: contains filter not applying to dimension table #8457

AdityaHegde merged 2 commits into from
Dec 9, 2025

Conversation

@AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Dec 5, 2025

We were removing any like/ilike filter when there was no search in dimension table. This is probably some legacy code that is not relevant anymore.

Removing this since we have ilike filters now with contains

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!
@AdityaHegde AdityaHegde merged commit cd295e2 into main Dec 9, 2025
11 checks passed
@AdityaHegde AdityaHegde deleted the fix/contains-filter-not-applying-to-dimension-table branch December 9, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@AdityaHegde @ericpgreen2