ClickHouse Cloud Port Selector #8458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checked measure dimension drodpown which is using select and no discernable differences
royendo
commented
Dec 5, 2025
royendo
commented
Dec 5, 2025
ericpgreen2
approved these changes
Dec 8, 2025
| label={property.displayName} | ||
| placeholder={property.placeholder} | ||
| optional={!property.required} | ||
| optional={property.required} |
Contributor
There was a problem hiding this comment.
It looks like the original was correct? Shouldn't optional === !required?
Contributor
Author
There was a problem hiding this comment.
Is port optional?
Id assume its required since we make them choose between two optinos
Contributor
Author
There was a problem hiding this comment.
ah looks like it effects both forms. will return it.
Contributor
Author
There was a problem hiding this comment.
actually no, this is what happens if you try to remove port
Contributor
Author
There was a problem hiding this comment.
So, since the UI form errors with port is removed, i will consider it as "required" and remove the optional tag.
I dont want to add any additional changes to this PR, so if this is a bug, we can create a new PR to deal with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here
Checklist: