Skip to content

Add download token size limit and nicer error message #8473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
begelundmuller merged 2 commits into from
Dec 10, 2025
Merged

Add download token size limit and nicer error message #8473

begelundmuller merged 2 commits into from
Dec 10, 2025

Conversation

@begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Dec 9, 2025 •
edited
Loading

  • The download token size limit is 7.5 KB (to ensure HTTP headers stay under 8 KB)
  • The size limit is applied after compressing the token
  • If exceeded, the returned error is:
download token size %d exceeds maximum allowed size of %d bytes (hint: this may be due to too many filter values)

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!
@begelundmuller begelundmuller self-assigned this Dec 9, 2025
@begelundmuller begelundmuller merged commit 0891b05 into main Dec 10, 2025
11 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/download-token-limits branch December 10, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@begelundmuller @mindspank