fix: canvas workspace sequencing #8518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
CanvasProviderto separate out its two responsibilities:CanvasInitializationcomponent responsible for accessing existing canvases or initializing new ones as well as providing slot props for the status of the initializationCanvasLoadingStatecomponent that takes in these slot props and renders out the appropriate loading spinners or error messagesIn all places besides the CanvasWorkspace, this results in no fundamental changes.
In CanvasWorkspace, the structure has been altered so that
CanvasInitializationwraps the entire workspace andCanvasLoadingStateis used around only the Canvas preview surface.On the CanvasWorkspace, this solves a bug where the
readystate was being reset when the canvas name changed.Checklist: