Skip to content

Conversation

@AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Dec 17, 2025

We decreased the min-height of chat input but the placeholder in dashboard chat can be cutoff. This is a hotfix for the immediate release, we need a better solution in the long term.

Screenshot 2025-12-17 at 10 18 46 AM

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!
@AdityaHegde AdityaHegde added the blocker A release blocker issue that should be resolved before a new release label Dec 17, 2025
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintended side effect on FullPageChat and InlineChat

The dashboardChatConfig object is shared across multiple components:

  • ExploreChat.svelteSidebarChat (dashboard sidebar chat)
  • FullPageChat.svelte (lines 73 and 84)
  • InlineChat.svelte (line 36)

Since FullPageChat and InlineChat hardcode dashboardChatConfig, they also inherit the increased minChatHeight of min-h-[4rem]. I noticed this regression on the full-page chat, which previously had a smaller height– which we should retain.

Additionally, the naming seems off - FullPageChat and InlineChat are used in the project context, not the dashboard/explore context, so having them reference dashboardChatConfig is confusing. These should probably use a projectChatConfig or generic chatConfig instead.


Developed in collaboration with Claude Code

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See finding above. We should not change the height of the FullPageChat input. Approving so you can merge when ready.

@AdityaHegde AdityaHegde merged commit c0b6f8d into main Dec 18, 2025
10 checks passed
@AdityaHegde AdityaHegde deleted the fix/dashboard-chat-placeholder-cutoff branch December 18, 2025 06:13
AdityaHegde added a commit that referenced this pull request Dec 18, 2025
* fix: dashboard chat placeholder is cutoff

* Fix for full page chat
k-anshul pushed a commit that referenced this pull request Dec 18, 2025
* fix: dashboard chat placeholder is cutoff

* Fix for full page chat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocker A release blocker issue that should be resolved before a new release

3 participants