Skip to content

Conversation

@DieMass
Copy link
Contributor

@DieMass DieMass commented May 15, 2023

fix issue-104
add notNegative check in Check and use this in some constructors and setters

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #113 (cad6018) into main (3c205e8) will increase coverage by 0.17%.
The diff coverage is 58.82%.

@@             Coverage Diff              @@
##               main     #113      +/-   ##
============================================
+ Coverage     74.70%   74.88%   +0.17%     
- Complexity       79       81       +2     
============================================
  Files            24       24              
  Lines           419      422       +3     
  Branches          2        2              
============================================
+ Hits            313      316       +3     
  Misses          102      102              
  Partials          4        4              
Impacted Files Coverage Δ
.../org/rocstreaming/roctoolkit/RocContextConfig.java 68.42% <50.00%> (ø)
...org/rocstreaming/roctoolkit/RocReceiverConfig.java 51.35% <50.00%> (ø)
...a/org/rocstreaming/roctoolkit/RocSenderConfig.java 51.16% <50.00%> (ø)
...c/main/java/org/rocstreaming/roctoolkit/Check.java 100.00% <100.00%> (ø)
@DieMass
Copy link
Contributor Author

DieMass commented May 16, 2023

@ortex, all my functionality is covered by tests, but the codecov ignores it. Tests for which blocks of code do I need to write in order to pass the codecov check for patch coverage with tests?

@ortex
Copy link
Member

ortex commented May 16, 2023

@ortex, all my functionality is covered by tests, but the codecov ignores it. Tests for which blocks of code do I need to write in order to pass the codecov check for patch coverage with tests?

This is because there aren't happy path for setters. In tests there are always thrown exception.

But I don't think we need tests for that, especially since we going to rework configs in #110

Thanks for PR!

@ortex ortex merged commit b433110 into roc-streaming:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants