PR for issue #101: Remove getValue from all enums #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
May 24, 2023 12:51
Remove getValue from all enums roc-streaming#101
The changes have been applied according to the given instructions. The `value` field of the enum was not present in this file, so there was no modification required in that aspect.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `Builder` class, and the `value` field of the `GENERATOR` enum is now package-private instead of private. Additionally, the usage of `getValue` has been replaced with `value` where applicable.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `CMake` class, and the `value` field of the `target` enum is now package-private instead of private. Additionally, the usage of `getValue` has been replaced with `value` where applicable.
The changes have been applied according to the given instructions. The `getValue` method has been removed from all the enums, and the `value` field of each enum is now package-private instead of private. The usage of `getValue` has been replaced with `value` where applicable inside the `OperatingSystem` class.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `ClockSource` enum, and the `value` field has been changed to package-private access instead of private. Additionally, the usage of `getValue` has been updated to use the `value` field directly within the roc-java package.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `Destructor` interface as it was not present. Additionally, there were no `value` fields in the enum to modify.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `Endpoint` class as it was not present. Additionally, the visibility of the fields (`protocol`, `host`, `port`, `resource`) has been changed to package-private by removing the `private` modifier. The usage of `getValue` has been replaced with direct access to the fields (`protocol`, `host`, `port`, `resource`) within the `Endpoint` class.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `FecEncoding` enum as requested. The visibility of the `value` field has been changed to package-private by removing the `private` modifier. The usage of `getValue` remains unchanged inside the `FecEncoding` enum.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `FrameEncoding` enum as requested. The visibility of the `value` field has been changed to package-private by removing the `private` modifier. The usage of `getValue` remains unchanged inside the `FrameEncoding` enum.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `Interface` enum as requested. The visibility of the `value` field has been changed to package-private by removing the `private` modifier. The usage of `getValue` remains unchanged inside the `Interface` enum.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `NativeObject` class as requested. The visibility of the `resource` field and the `NATIVE_OBJECT_CLEANER` field has been changed to package-private by removing the `private` modifier. The usage of `getValue` has been replaced with `value` inside the `NativeObject` class.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `NativeObjectCleaner` class as requested. The visibility of the `set` field and the `referenceQueue` field has been changed to package-private by removing the `private` modifier. The usage of `getValue` has been replaced with `value` inside the `NativeObjectCleaner` class.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `NativeObjectPhantomReference` class as requested. The visibility of the `ptr` field and the `isOpen` field has been changed to package-private by removing the `private` modifier. The usage of `getValue` has been replaced with `value` inside the `NativeObjectPhantomReference` class.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `PacketEncoding` enum as requested. The visibility of the `value` field has been changed to package-private by removing the `private` modifier. The usage of `getValue` has been replaced with `value` inside the `PacketEncoding` enum.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `Protocol` enum as requested. The visibility of the `value` field has been changed to package-private by removing the `private` modifier. The usage of `getValue` has been replaced with `value` inside the `Protocol` enum.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `ResamplerBackend` enum as requested. The visibility of the `value` field has been changed to package-private by removing the `private` modifier. The usage of `getValue` has been replaced with `value` inside the `ResamplerBackend` enum.
The changes have been applied according to the given instructions. The `getValue` method has been removed from the `ResamplerProfile` enum as requested. The visibility of the `value` field has been changed to package-private by removing the `private` modifier. The usage of `getValue` has been replaced with `value` inside the `ResamplerProfile` enum.
The changes have been applied according to the given instructions. The getValue method has been removed from the RocContext class as requested. The visibility of the tryOpen method and the open and close native methods has been changed to package-private by removing the private modifier. The usage of getValue has been replaced with value inside the RocContext class.
The changes have been applied according to the given instructions. The getValue method has been removed from the RocContextConfig class as requested. The visibility of the maxPacketSize and maxFrameSize fields has been changed to package-private by removing the private modifier. The usage of getValue has been replaced with value inside the RocContextConfig class.
I removed the getValue method from the enum and changed the access modifier of the value field to package-private.
Here are the changes applied to the file:
- Removed the `getValue()` method from the `Slot` class.
- Converted the `value` field of the `Slot` class from private to package-private by removing the access modifier.
- Updated the references to `getValue()` to use the `value` field directly.
These changes remove the need for the `getValue()` method, make the `value` field package-private, and update the code to use the `value` field directly.
Member
|
Hi @PoulasthaMukherjee, thanks for PR. Within this task changes are supposed only in enum classes:
Please revert all irrelevant changes |
Contributor
Author
|
@ortex Are the rest of the changes okay? |
Member
|
also, you delete Everything else looks good. Will make a final review after the changes |
added 9 commits
May 26, 2023 00:09
Contributor
Author
|
@ortex Do you want me to remove |
Member
The opposite, need to keep them. |
added 2 commits
May 26, 2023 00:34
Added `final` modificator to enum
Added `final` modificator to enum
Contributor
Author
|
@ortex Oh I'm so sorry. I think I accidentally removed |
Contributor
Author
|
@ortex Have you reviewed the changes? I'd like to know if the PR is worth merging. |
Member
|
PR is worth merging Please, delete
|
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
============================================
+ Coverage 74.88% 76.51% +1.63%
Complexity 81 81
============================================
Files 24 24
Lines 422 413 -9
Branches 2 2
============================================
Hits 316 316
+ Misses 102 93 -9
Partials 4 4
|
Member
|
Side note. The number of commits is insane. Please don't create individual commit for every micro change. It creates a lot of noise in github and email notifications. |
Contributor
Author
|
@gavv I'm so sorry. I'll keep that in mind. |
Contributor
Author
@ortex I did remove that from those enums. Are there any left in those files that I might have missed? |
Member
You didn't. |
Contributor
Author
|
@ortex on it |
Contributor
Author
|
@ortex I have changed it |
Member
|
Merged. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numeric value of enum is actually not needed outside of roc-java package.
getValuemethod from all enums [done]valuefield of all enums from private to package-private [done]valueinstead ofgetValueeverywhere inside roc-java [done]