Fix logger test on recent libroc #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ortex
reviewed
Apr 3, 2023
| .until(() -> { | ||
| boolean hasLogOpen = false, hasLogClose = false; | ||
| for (String s : logs) { | ||
| if (s.contains(logOpen)) { |
Member
There was a problem hiding this comment.
nit: maybe replace contains with startsWith ?
ortex
reviewed
Apr 3, 2023
| .untilAsserted(() -> assertTrue(logs.contains(logOpen) && logs.contains(logClose))); | ||
| .until(() -> { | ||
| boolean hasLogOpen = false, hasLogClose = false; | ||
| for (String s : logs) { |
ortex
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On recent libroc (not released yet, but already installed on my system), in log messages parenthesis were added to function names when they were missing, e.g.
roc_context_openwas replaced withroc_context_open().Due to this, logger test hangs on my system. I modified the test to work on both old and new version, by relaxing log messages matching.