Skip to content

add debug logs; remove custom handler api #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ortex merged 3 commits into from
May 31, 2023
Merged

add debug logs; remove custom handler api #97

ortex merged 3 commits into from
May 31, 2023

Conversation

@ortex
Copy link
Member

@ortex ortex commented May 11, 2023

fix #53

  • remove custom logging handler api
  • added debug logs
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Merging #97 (90caf01) into main (5923abd) will decrease coverage by 17.00%.
The diff coverage is 100.00%.

❗ Current head 90caf01 differs from pull request most recent head 5c36d78. Consider uploading reports for the commit 5c36d78 to get more accurate results

@@              Coverage Diff              @@
##               main      #97       +/-   ##
=============================================
- Coverage     94.96%   77.96%   -17.00%     
- Complexity       82       92       +10     
=============================================
  Files            24       24               
  Lines           258      472      +214     
  Branches          2        2               
=============================================
+ Hits            245      368      +123     
- Misses            9      100       +91     
  Partials          4        4
Impacted Files Coverage Δ
...in/java/org/rocstreaming/roctoolkit/Interface.java 100.00% <ø> (ø)
...ain/java/org/rocstreaming/roctoolkit/Endpoint.java 100.00% <100.00%> (ø)
...java/org/rocstreaming/roctoolkit/NativeObject.java 100.00% <100.00%> (ø)
...g/rocstreaming/roctoolkit/NativeObjectCleaner.java 86.95% <100.00%> (+2.74%) ⬆️
...n/java/org/rocstreaming/roctoolkit/RocContext.java 100.00% <100.00%> (ø)
.../org/rocstreaming/roctoolkit/RocContextConfig.java 70.00% <100.00%> (-30.00%) ⬇️
...n/java/org/rocstreaming/roctoolkit/RocLibrary.java 100.00% <100.00%> (ø)
...in/java/org/rocstreaming/roctoolkit/RocLogger.java 82.35% <100.00%> (-6.11%) ⬇️
.../java/org/rocstreaming/roctoolkit/RocReceiver.java 97.29% <100.00%> (+2.56%) ⬆️
...org/rocstreaming/roctoolkit/RocReceiverConfig.java 52.00% <100.00%> (-48.00%) ⬇️
... and 3 more

... and 10 files with indirect coverage changes
@ortex ortex force-pushed the debug-logs branch 2 times, most recently from 5a0e594 to 5669d63 Compare May 11, 2023 20:31
gavv
gavv reviewed May 13, 2023
View reviewed changes
@gavv gavv added the status: needs revision Pull request should be revised by its author label May 13, 2023
@ortex ortex force-pushed the debug-logs branch 2 times, most recently from f8987af to 90db3c6 Compare May 13, 2023 14:05
@ortex ortex added status: ready for review Pull request can be reviewed and removed status: needs revision Pull request should be revised by its author labels May 16, 2023
gavv
gavv reviewed May 21, 2023
View reviewed changes
@gavv gavv added status: needs revision Pull request should be revised by its author and removed status: ready for review Pull request can be reviewed labels May 21, 2023
@ortex ortex added status: ready for review Pull request can be reviewed and removed status: needs revision Pull request should be revised by its author labels May 25, 2023
@gavv
Copy link
Member

gavv commented May 31, 2023

TODO: remove hand-crafted toString from *Config
@gavv
Copy link
Member

gavv commented May 31, 2023

Regarding naming: what about renaming tryOpen+destructor to constructor+destructor or construct+destroy or tryConstruct+destroy?
@gavv gavv added status: needs revision Pull request should be revised by its author and removed status: ready for review Pull request can be reviewed labels May 31, 2023
@ortex ortex merged commit eed89cd into main May 31, 2023
@ortex ortex deleted the debug-logs branch May 31, 2023 20:21
@gavv gavv removed the status: needs revision Pull request should be revised by its author label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@ortex @gavv