Add Journal of Educational Data Mining#251
Conversation
cderv
left a comment
There was a problem hiding this comment.
Hi @jooyoungseo !
For this one too can you verified your PR following the PR template ?
https://github.com/rstudio/rticles/blob/master/.github/PULL_REQUEST_TEMPLATE.md
I don't think there is much missing. Only a new test maybe for this format.
I'll deal with all the conflicts afterward unless you are used to do that - If not don't worry.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
JooYoung Seo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
[skip ci]
[skip ci]
[skip ci]
[skip ci]
cderv
left a comment
There was a problem hiding this comment.
This was long overdue. I made the necessary change for this one.
I believe this is working as expected now.
|
Perfect. Thanks! |
Changes
jedm_article()function inarticle.R.README.md;DESCRIPTION; andNEWS.md.Building
Rd2roxygen::rab()function to buildrticlespackage after change has been made.Testing
I have confirmed that
rticles::jedm_article()output format works.Signed-Form