Conversation
I'm still stuck on a version that's 1.5 years old!
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
I have no idea what this does but...seems fine? |
|
It makes it a bit simpler to update if you aren't using MELPA. Maybe we also need to push a tag to make melpa-stable bump? See #87 |
|
So...shall we land it? :) |
|
Could you please tag the branch also =)? |
|
Thanks for shipping!
…On Tue, Jun 26, 2018 at 4:21 PM Aleksandr Ivanov ***@***.***> wrote:
Could you please tag the branch also =)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#267 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA2KlgStIQnCiZRACRuNtDvLxS42cZfUks5uAsHhgaJpZM4Tg0cs>
.
|
|
sorry for the lack of action here for months; clearly the people with all the power here haven't accepted all the associated responsibility. |
I'm still stuck on a version that's 1.5 years old!