Don't hang when the beginning of the error can't be found#576
Open
dabrahams wants to merge 1 commit intorust-lang:masterfrom
Open
Don't hang when the beginning of the error can't be found#576dabrahams wants to merge 1 commit intorust-lang:masterfrom
dabrahams wants to merge 1 commit intorust-lang:masterfrom
Conversation
Tools that interfere with rustc output can cause the line to be prefixed (see DioxusLabs/dioxus#4547), which can cause the line never to be found, and the loop to continue until the user presses C-g
psibi
reviewed
Sep 25, 2025
Member
psibi
left a comment
psibi
left a comment
There was a problem hiding this comment.
Overall, this looks good to me. Can you add a test for this?
jcs090218
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools that interfere with rustc output can cause the line to be prefixed (see DioxusLabs/dioxus#4547), which can cause the line never to be found, and the loop to continue until the user presses C-g