Skip to content

Rename mingw-* CI jobs to pr-* #143294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename mingw-* CI jobs to pr-* #143294

wants to merge 1 commit into from
+80 −81

Conversation

ChrisDenton
Copy link
Member

The name mingw confuses people because these CI jobs now do much more than just cross-compile to mingw.

This is basically a find/replace. I chose the name pr- because it's job is to do general PR checks,
@rustbot
Copy link
Collaborator

rustbot commented Jul 1, 2025

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 1, 2025

There are changes to the tidy tool.

cc @jieyouxu

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee
Copy link
Member

Run set +e
info: removing rustup home
info: removing cargo home
info: removing rustup binaries
info: rustup is uninstalled
Invalid image: pr-check-tidy
Error: Process completed with exit code 1.
@ChrisDenton
Copy link
Member Author

oh, I think having "mingw" in the name might be load-bearing...
workingjubilee
workingjubilee reviewed Jul 1, 2025
View reviewed changes
@Kobzol
Copy link
Contributor

Kobzol commented Jul 1, 2025

Heh, I was just thinking about this today :)

You need to rename the directory with the Dockerfile.
@ChrisDenton
Copy link
Member Author

Doh! That's totally obvious now that you mentioned it 😅
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
6 participants
@ChrisDenton @rustbot @rust-log-analyzer @workingjubilee @Kobzol @jdno