powerpc64le_unknown_freebsd.rs: link with -lgcc#158646
Open
pkubaj wants to merge 1 commit into
Open
Conversation
Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double. 128 bit arithmetics are implemented in LLVM's compiler_rt, which is FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0 succeeds - noop for earlier releases.
Collaborator
|
These commits modify compiler targets. |
Collaborator
|
r? @camelid rustbot has assigned @camelid. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
bjorn3
reviewed
Jul 1, 2026
| // long double is IEEE-128; f128 soft-float ops emit the PPC __*kf* helpers, | ||
| // which compiler_builtins lacks. Resolve them from base libgcc. | ||
| base.late_link_args.entry(LinkerFlavor::Gnu(Cc::Yes, Lld::No)).or_default().push("-lgcc".into()); | ||
| base.late_link_args.entry(LinkerFlavor::Gnu(Cc::Yes, Lld::Yes)).or_default().push("-lgcc".into()); |
Member
There was a problem hiding this comment.
Maybe use add_link_args(&mut base.late_link_args, LinkerFlavor::Gnu(Cc::Yes, Lld::No), &["-lgcc"]);? That will add the args both with and without lld.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double. 128 bit arithmetics are implemented in LLVM's compiler_rt, which is FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0 succeeds - noop for earlier releases.