TLS Encryption Optimization #68521
Open
TLS Encryption Optimization #68521
+3,840
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwoz
force-pushed
the
ssl_transport_tests
branch
from
52dae2a to
38bb7f5
Compare
Adds disable_aes_with_tls config option that eliminates redundant AES encryption when TLS with mutual authentication is active, providing 10-50% performance improvement with 6 security checks including certificate identity verification.
Main Issue: Tests were checking for SSL handshake failures too early. With Tornado's lazy SSL handshaking, TCP connections succeed immediately, but SSL validation happens asynchronously.
test_tcp_ssl.py (20 lines changed):
- Timing fix: Added await asyncio.sleep(1) after connect() to allow SSL handshake to fail
- Stream check: Verify connection closed by checking pub_client._stream.closed()
- Exception handling: Added ssl.SSLError to expected exceptions
- Test isolation: Added minion_opts.pop("ssl", None) to prevent state contamination
- Cleanup: Added process_manager.terminate() for proper process cleanup
- Imports: Added import ssl and import salt.utils.process
test_ws_ssl.py (3 lines changed):
- Test isolation: Added minion_opts.pop("ssl", None)
- Cleanup: Added process_manager.terminate()
These minimal changes fix the test expectations to match the actual async SSL behavior while ensuring proper isolation and cleanup between tests.
Address PR review feedback from twangboy: - TLS Encryption Optimization header: Remove extra = character - Certificate Identity Requirement header: Remove extra - character RST section headers require exact character count matching the title length.
Improve changelog description and fix typo (alid -> valid). Provide more comprehensive description of the feature.
dwoz
force-pushed
the
ssl_transport_tests
branch
from
1486cf9 to
6961226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds disable_aes_with_tls config option that eliminates redundant AES encryption when TLS with mutual authentication is active, providing performance improvement with 6 security checks including certificate identity verification.
Fixes: #68536