docs: fix invalid Noto Sans font configuration for OG images#612
Open
zerone0x wants to merge 1 commit intosatnaing:mainfrom
Open
docs: fix invalid Noto Sans font configuration for OG images#612zerone0x wants to merge 1 commit intosatnaing:mainfrom
zerone0x wants to merge 1 commit intosatnaing:mainfrom
Conversation
Remove duplicate `:wght@700` from font property in the Noto Sans font configuration example. The weight is already passed separately to the `loadGoogleFont` function, so having `:wght@700` in the font string causes the generated URL to have a duplicate weight parameter like `Noto+Sans:wght@700:wght@700`, which breaks the Google Fonts API request. Fixes satnaing#499 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes invalid font configuration in the dynamic OG image documentation. The example code for using Noto Sans fonts contained duplicate
:wght@700in the font property, which causes the Google Fonts API request to fail.The
loadGoogleFontfunction already appends:wght@${weight}to the font URL, so having:wght@700in thefontproperty creates an invalid URL likeNoto+Sans:wght@700:wght@700.Types of changes
Checklist
Further comments
Before this fix, users following the documentation would encounter errors when generating OG images with Noto Sans fonts because the Google Fonts API would return an error for the malformed URL.
Related Issue
Closes: #499
🤖 Generated with Claude Code