Skip to content

Conversation

@DarkIsDude
Copy link
Contributor

@DarkIsDude DarkIsDude commented Dec 17, 2025

⚠️ Do not merge without my approval

Pull request template

Description

Support a new header x-amz-object-optional-attributes to be able to retrieve in the ListObjectsV2 user metadata.

Motivation and context

https://github.com/scality/citadel/pull/301/changes

https://scality.atlassian.net/browse/CLDSRV-812

Related issues

scality/Arsenal#2581 is needed as the bump of Arsenal in Vault.

A new MR will be opened to update the response of ListObjectsV2 and return asked fields.

@DarkIsDude DarkIsDude self-assigned this Dec 17, 2025
@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2025

Hello darkisdude,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-812 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.2.11

Please check the Fix Version/s of CLDSRV-812, or the target
branch of this pull request.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.36%. Comparing base (c8fe018) to head (535b360).
⚠️ Report is 2 commits behind head on development/9.2.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...i/apiUtils/authorization/prepareRequestContexts.js 83.33% 1 Missing ⚠️
lib/api/bucketGet.js 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...i/apiUtils/authorization/prepareRequestContexts.js 94.57% <83.33%> (-0.55%) ⬇️
lib/api/bucketGet.js 96.24% <85.71%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.2    #6033      +/-   ##
===================================================
+ Coverage            84.34%   84.36%   +0.01%     
===================================================
  Files                  204      204              
  Lines                12926    12935       +9     
===================================================
+ Hits                 10903    10912       +9     
  Misses                2023     2023              
Flag Coverage Δ
file-ft-tests 67.44% <76.92%> (+<0.01%) ⬆️
kmip-ft-tests 28.13% <0.00%> (-0.02%) ⬇️
mongo-v0-ft-tests 68.67% <76.92%> (-0.02%) ⬇️
mongo-v1-ft-tests 68.70% <76.92%> (+0.02%) ⬆️
multiple-backend 35.35% <69.23%> (+0.02%) ⬆️
sur-tests 35.70% <69.23%> (+0.06%) ⬆️
sur-tests-inflights 37.49% <69.23%> (-0.01%) ⬇️
unit 69.93% <84.61%> (+0.01%) ⬆️
utapi-v2-tests 34.37% <69.23%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@bert-e
Copy link
Contributor

bert-e commented Dec 18, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-812 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.2.12

Please check the Fix Version/s of CLDSRV-812, or the target
branch of this pull request.

@DarkIsDude DarkIsDude requested review from a team, SylvainSenechal and delthas December 18, 2025 16:39
@bert-e
Copy link
Contributor

bert-e commented Dec 18, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@DarkIsDude DarkIsDude marked this pull request as ready for review December 19, 2025 09:09
@DarkIsDude
Copy link
Contributor Author

/wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants