Fix make sure enabling `array_api_dispatch=True` does not break any estimator on NumPy inputs by ogrisel · Pull Request #32846 · scikit-learn/scikit-learn

ogrisel · 2025-12-05T15:22:37Z

This is a follow-up to #32840. This should detect most possible silent breaking in future refactoring of helper functions that are used by both in array API supporting and not supporting code in scikit-learn.

AI usage disclosure

I used AI assistance for:

Mostly bad code suggestions that I had to re-edit manually to get the code working correctly
Test/benchmark generation
Documentation (including examples)
Research and understanding

…imator on NumPy inputs

sklearn/utils/_array_api.py

doc/whats_new/upcoming_changes/array-api/32846.fix.rst

sklearn/utils/_array_api.py

…entation in the memoryviewslices unwrap helper

ogrisel · 2025-12-08T17:14:59Z

cc @lucyleeow @OmarManzoor @betatim @virchan

betatim · 2025-12-09T07:52:51Z

Only just getting to this. I asked @lesteve about the release schedule and he'd like to get 1.8.0 done more or less "now". I think it would be nice to have this PR in, but it will take more than five minutes to review. For me it is ok to send 1.8.0 off without this merged.

I can understand that at some point you need to decide "the 1.8 boat has left, you are too late". Even though it makes me sad to ship it with a bug that we know about. Maybe having a small bug is ok (there are probably more that we haven't yet found) - we will find out if someone tried array API support because they'll report an issue ;)

OmarManzoor

Thank you for the PR @ogrisel

sklearn/utils/_array_api.py

sklearn/utils/estimator_checks.py

ogrisel · 2025-12-09T14:36:34Z

@betatim I think the release-critical bugfixes have already all been merged. This one can indeed wait and this is why I did not milestone it. We can take our time to review carefully, no hurry.

Co-authored-by: Omar Salman <omar.salman2007@gmail.com>

OmarManzoor · 2025-12-09T16:14:03Z

@ogrisel There is a CI failure which seems unrelated to this PR but still seems like something erroneous

OmarManzoor

LGTM. Thank you @ogrisel

ogrisel · 2025-12-10T08:43:51Z

There is a CI failure which seems unrelated to this PR but still seems like something erroneous

Indeed, there is a missing rng seed. Let me open a dedicated PR.

…rs-on-numpy-inputs

lucyleeow

LGTM, thanks for the other fixes here. Nits only

sklearn/utils/_array_api.py

sklearn/utils/tests/test_array_api.py

lucyleeow · 2025-12-12T04:21:51Z

sklearn/utils/estimator_checks.py

+    When expect_only_array_outputs is False, the check accepts non-array
+    outputs from estimator methods (e.g., sparse data structures). This is


Could you expand on this? I was confused just reading this, but https://github.com/scikit-learn/scikit-learn/pull/32846/changes#r2602981393 cleared it up for me.

I pushed 969f06a as an attempt to clarify this.

Thanks! Feel free to merge when you're ready!

sklearn/utils/estimator_checks.py

Co-authored-by: Lucy Liu <jliu176@gmail.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com>

Co-authored-by: Lucy Liu <jliu176@gmail.com>

sklearn/utils/estimator_checks.py

…rs-on-numpy-inputs

OmarManzoor · 2026-01-06T12:56:00Z

@ogrisel Should we merge this?

sklearn/utils/estimator_checks.py

betatim

One tweak to a comment, for me it made it easier to understand. Otherwise LGTM, let's merge

Co-authored-by: Tim Head <betatim@gmail.com>

…rs-on-numpy-inputs

ogrisel added 2 commits December 5, 2025 16:11

Fix make sure enabling array_api_dispatch=True does not break any est…

40c7c82

…imator on NumPy inputs

Better check_array_api_input docstring and parameter name

5f865e1

ogrisel added this to Array API Dec 5, 2025

ogrisel added the Array API label Dec 5, 2025

github-actions bot added module:decomposition module:utils labels Dec 5, 2025

ogrisel commented Dec 5, 2025

View reviewed changes

sklearn/utils/_array_api.py Outdated Show resolved Hide resolved

Add changelog entry

30a67a9

ogrisel added the CUDA CI label Dec 5, 2025

github-actions bot removed the CUDA CI label Dec 5, 2025

ogrisel changed the title ~~Fix make sure enabling array_api_dispatch=True does not break any estimator on NumPy inputs~~ Dec 5, 2025

Alternative way to handle sliced memory views and list/tuple inputs

bd5b9fb

ogrisel moved this to In Progress in Array API Dec 5, 2025

ogrisel added the CUDA CI label Dec 5, 2025

github-actions bot removed the CUDA CI label Dec 5, 2025

ogrisel commented Dec 5, 2025

View reviewed changes

doc/whats_new/upcoming_changes/array-api/32846.fix.rst Show resolved Hide resolved

ogrisel commented Dec 5, 2025

View reviewed changes

sklearn/utils/_array_api.py Show resolved Hide resolved

ogrisel added the Waiting for Reviewer label Dec 5, 2025

Add inline comment to explain the motivation behind the unsual implem…

7527de4

…entation in the memoryviewslices unwrap helper

OmarManzoor reviewed Dec 9, 2025

View reviewed changes

sklearn/utils/_array_api.py Outdated Show resolved Hide resolved

sklearn/utils/estimator_checks.py Outdated Show resolved Hide resolved

ogrisel and others added 2 commits December 9, 2025 15:37

Typo

e16f1f3

Co-authored-by: Omar Salman <omar.salman2007@gmail.com>

More consistent use of expect_only_array_outputs

bb4702b

ogrisel added the CUDA CI label Dec 9, 2025

github-actions bot removed the CUDA CI label Dec 9, 2025

OmarManzoor approved these changes Dec 9, 2025

View reviewed changes

Merge branch 'main' into array-api-dispatch-should-not-break-estimato…

474f49f

…rs-on-numpy-inputs

adrinjalali added this to Labs Dec 11, 2025

adrinjalali moved this to Todo in Labs Dec 11, 2025

adrinjalali assigned ogrisel Dec 11, 2025

adrinjalali moved this from Todo to In progress in Labs Dec 11, 2025

lucyleeow approved these changes Dec 12, 2025

View reviewed changes

lesteve reviewed Dec 15, 2025

View reviewed changes

sklearn/utils/estimator_checks.py Outdated Show resolved Hide resolved

ogrisel and others added 2 commits December 24, 2025 10:38

Apply suggestions from code review

b0edf2f

Co-authored-by: Lucy Liu <jliu176@gmail.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com>

Update sklearn/utils/_array_api.py

2aa78ed

Co-authored-by: Lucy Liu <jliu176@gmail.com>

ogrisel commented Dec 24, 2025

View reviewed changes

sklearn/utils/estimator_checks.py Outdated Show resolved Hide resolved

Update sklearn/utils/estimator_checks.py

969f06a

github-actions bot added the CI:Linter failure The linter CI is failing on this PR label Dec 24, 2025

ogrisel commented Dec 24, 2025

View reviewed changes

sklearn/utils/estimator_checks.py Outdated Show resolved Hide resolved

Trailing space.

1402744

github-actions bot removed the CI:Linter failure The linter CI is failing on this PR label Dec 24, 2025

Merge branch 'main' into array-api-dispatch-should-not-break-estimato…

7099aca

…rs-on-numpy-inputs

ogrisel added the CUDA CI label Dec 24, 2025

github-actions bot removed the CUDA CI label Dec 24, 2025

adrinjalali unassigned ogrisel Jan 6, 2026

betatim reviewed Jan 6, 2026

View reviewed changes

sklearn/utils/estimator_checks.py Outdated Show resolved Hide resolved

betatim approved these changes Jan 6, 2026

View reviewed changes

OmarManzoor and others added 2 commits January 6, 2026 18:41

Update sklearn/utils/estimator_checks.py

9d76a3f

Co-authored-by: Tim Head <betatim@gmail.com>

Merge branch 'main' into array-api-dispatch-should-not-break-estimato…

e745b5f

…rs-on-numpy-inputs

OmarManzoor enabled auto-merge (squash) January 6, 2026 13:42

OmarManzoor merged commit 938cd97 into scikit-learn:main Jan 6, 2026
36 checks passed

github-project-automation bot moved this from In progress to Done in Labs Jan 6, 2026

github-project-automation bot moved this from In Progress to Done in Array API Jan 6, 2026

lucyleeow mentioned this pull request Jan 7, 2026

TST Add common test for mixed array API inputs for metrics #32755

Open

ogrisel deleted the array-api-dispatch-should-not-break-estimators-on-numpy-inputs branch January 7, 2026 06:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix make sure enabling `array_api_dispatch=True` does not break any estimator on NumPy inputs#32846

Fix make sure enabling `array_api_dispatch=True` does not break any estimator on NumPy inputs#32846
OmarManzoor merged 15 commits intoscikit-learn:mainfrom
ogrisel:array-api-dispatch-should-not-break-estimators-on-numpy-inputs

ogrisel commented Dec 5, 2025

Uh oh!

Uh oh!

Uh oh!

ogrisel commented Dec 8, 2025

betatim commented Dec 9, 2025

OmarManzoor left a comment

Uh oh!

Uh oh!

ogrisel commented Dec 9, 2025

OmarManzoor commented Dec 9, 2025

OmarManzoor left a comment

ogrisel commented Dec 10, 2025

lucyleeow left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucyleeow Dec 12, 2025

ogrisel Dec 24, 2025

lucyleeow Dec 25, 2025

Uh oh!

Uh oh!

Uh oh!

OmarManzoor commented Jan 6, 2026

Uh oh!

betatim left a comment

Uh oh!

Labels

6 participants

		When expect_only_array_outputs is False, the check accepts non-array
		outputs from estimator methods (e.g., sparse data structures). This is

Uh oh!

Conversation

ogrisel commented Dec 5, 2025

AI usage disclosure

Uh oh!

Uh oh!

Uh oh!

ogrisel commented Dec 8, 2025

betatim commented Dec 9, 2025

OmarManzoor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ogrisel commented Dec 9, 2025

OmarManzoor commented Dec 9, 2025

OmarManzoor left a comment

Choose a reason for hiding this comment

ogrisel commented Dec 10, 2025

lucyleeow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucyleeow Dec 12, 2025

Choose a reason for hiding this comment

ogrisel Dec 24, 2025

Choose a reason for hiding this comment

lucyleeow Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

OmarManzoor commented Jan 6, 2026

Uh oh!

betatim left a comment

Choose a reason for hiding this comment

Uh oh!

Labels

6 participants