Skip to content

Add array API support for FeatureUnion#33263

Merged
OmarManzoor merged 2 commits intoscikit-learn:mainfrom
ogrisel:feature-union-array-api
Feb 12, 2026
Merged

Add array API support for FeatureUnion#33263
OmarManzoor merged 2 commits intoscikit-learn:mainfrom
ogrisel:feature-union-array-api

Conversation

@ogrisel
Copy link
Member

@ogrisel ogrisel commented Feb 11, 2026

While working on an array API demo, I realized that FeatureUnion did not support array API even when the underlying transformers do. Here is a fix.

AI usage disclosure

I used AI assistance for:

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

I used cursor but manually reviewed and improved the generated code.

@ogrisel ogrisel changed the title Add array API support for FeatureUnion Feb 11, 2026
@ogrisel ogrisel added the Quick Review For PRs that are quick to review label Feb 11, 2026
@github-actions github-actions bot removed the CUDA CI label Feb 12, 2026
Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @ogrisel!

@virchan virchan added the Waiting for Second Reviewer First reviewer is done, need a second one! label Feb 12, 2026
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you Olivier!

@github-actions github-actions bot removed the CUDA CI label Feb 12, 2026
@OmarManzoor OmarManzoor merged commit 79932ba into scikit-learn:main Feb 12, 2026
58 checks passed
@ogrisel ogrisel deleted the feature-union-array-api branch February 12, 2026 09:08
lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Array API module:pipeline Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one!

3 participants