Skip to content

Conversation

@gusye1234
Copy link
Contributor

add an image classification demo for PyTorch backend

@juntao
Copy link
Member

juntao commented Jul 23, 2022

Shall we use wasmedge-nn in this example?

@apepkuss
Copy link
Member

Hi @gusye1234

I recently created feat-wasmedge-wasi-nn branch in wasmedge-nn to support PyTorch. If you have interest in it, you can introduce the repo in your PyTorch example project.

@gusye1234
Copy link
Contributor Author

Hi @gusye1234

I recently created feat-wasmedge-wasi-nn branch in wasmedge-nn to support PyTorch. If you have interest in it, you can introduce the repo in your PyTorch example project.

Will try it on!

Signed-off-by: Jianbai Ye <jianbaiye@outlook.com>
@gusye1234
Copy link
Contributor Author

gusye1234 commented Aug 13, 2022

Hi @apepkuss , seem like you didn't sign your commits: 32a0cc9, b0b7ae6, 96e5118, and that blocks this PR's merging cause I rebased on the master branch😂.

@apepkuss
Copy link
Member

@gusye1234 I checked the previous PR #7, #8, and also #10, in which all commits were signed. The snapshot below shows the original branch for creating PR #10, in which all commits were signed-off.

image

Do we have to use a GPG key to sign the commits?

@juntao Is it required to sign off all commits with a GPG key?

@hydai
Copy link
Member

hydai commented Aug 13, 2022

@gusye1234 @apepkuss Looks like the signed commit is required is enabled, which asks developers should use gpg sign for every commit. I just disabled it. So it should be fine now.

@apepkuss
Copy link
Member

@hydai Thanks a lot!

Copy link
Member

@q82419 q82419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upload the .pt and the steps to generate the model file.

Signed-off-by: Jianbai Ye <jianbaiye@outlook.com>
Signed-off-by: Jianbai Ye <jianbaiye@outlook.com>
Signed-off-by: Jianbai Ye <jianbaiye@outlook.com>
@q82419 q82419 merged commit bc486ad into second-state:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants