Skip to content

Clearup type and documentation - #15

Merged
zyc9012 merged 5 commits into
masterfrom
cleanup
Jun 28, 2023
Merged

Clearup type and documentation#15
zyc9012 merged 5 commits into
masterfrom
cleanup

Conversation

@zyc9012

@zyc9012 zyc9012 commented Jun 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Remove all types for engine parameters and responses
  • Clear up documentation
  • Clarify that https://serpapi.com/search-api is the only source of truth for valid engines and parameters.
    • Both in documentation and editor hint.

image
image
image
image
@zyc9012
zyc9012 marked this pull request as ready for review June 5, 2023 00:27
@zyc9012
zyc9012 requested a review from aciddjus June 5, 2023 00:27
aciddjus
aciddjus approved these changes Jun 28, 2023
View reviewed changes

@aciddjus aciddjus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zyc9012 💯
LGTM!
@zyc9012
zyc9012 merged commit ecea6dc into master Jun 28, 2023
@zyc9012
zyc9012 deleted the cleanup branch June 28, 2023 09:46
@zyc9012 zyc9012 mentioned this pull request Mar 31, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@zyc9012 @aciddjus