fix(v4-charts): fix dark mode support for custom pie label#11013
Open
amalgio wants to merge 1 commit into
Open
fix(v4-charts): fix dark mode support for custom pie label#11013amalgio wants to merge 1 commit into
amalgio wants to merge 1 commit into
Conversation
Contributor
|
@amalgio is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
amalgio
force-pushed
the
fix/chart-pie-dark-mode
branch
from
4c2c0f7 to
f17f7ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where the custom pie chart labels in
chart-pie-label-customare invisible in dark mode (they remain static black).Why this happens
The component used
fill="var(--foreground)"directly on the<text>element. In shadcn themes,--foregroundholds raw HSL numbers (e.g.,240 10% 3.9%) without thehsl()wrapper. This results in an invalid SVG fill property, causing the browser to fall back to default black text in both light and dark modes.The Fix
Changed
fill="var(--foreground)"toclassName="fill-foreground". This allows Tailwind to correctly apply the CSS rulefill: hsl(var(--foreground)), enabling proper theme-aware styling.