fix(cli): reject unsafe registry file paths#11035
Draft
mikerewak wants to merge 1 commit into
Draft
Conversation
Contributor
|
@mikerewak is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Can you sign the commits please? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rejects unsafe registry file paths before the CLI writes component files into a project. Relative paths that stay under the intended target continue to work; absolute paths and parent-directory escapes are rejected.
Tested with:
git diff --checknpx --yes esbuild@0.27.1 packages/shadcn/src/utils/add-components.ts packages/shadcn/src/utils/add-components.test.ts --bundle --platform=node --format=esm --packages=external --outdir=/tmp/shadcn-add-components-checkThe focused Vitest target could not be run in this checkout because pnpm/node_modules were unavailable.