fix(empty): correct EmptyDescription prop type from ComponentProps<"p"> to ComponentProps<"div">#11058
Open
FrancoKaddour wants to merge 1 commit into
Open
Conversation
Contributor
|
@FrancoKaddour is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
… ComponentProps<"div"> EmptyDescription renders a <div> element but was typed as React.ComponentProps<"p">. All other Empty sub-components correctly match their type annotation to their rendered element. Fixed across all 21 theme variants.
FrancoKaddour
force-pushed
the
fix/empty-description-type-mismatch
branch
from
457f663 to
c456d16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmptyDescription renders a
This inconsistency means the type annotation misrepresents what the component actually renders. The fix is to align the type with the rendered element across all 21 theme variants (new-york-v4, base, radix, and all style variants).
No behavior change — purely a type correction.