Skip to content

fix(executor): add exponential backoff retry for transient LLM provid… #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rabba-Meghana wants to merge 5 commits into
base: main
Choose a base branch
from
+205 −3
Open

fix(executor): add exponential backoff retry for transient LLM provid… #3773

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f887e9
fix(executor): add exponential backoff retry for transient LLM provid…
Rabba-Meghana Mar 25, 2026
70ce97f
fix(executor): address code review feedback on retry logic
Rabba-Meghana Mar 25, 2026
0b7a84f
fix(executor): extend Retry-After to 529 and fix network error test
Rabba-Meghana Mar 25, 2026
5c8c135
fix(executor): cap Retry-After delay by maxDelayMs to prevent timeout…
Rabba-Meghana Mar 25, 2026
d6e45a2
fix(executor): clamp jitter within maxDelayMs to honour delay cap
Rabba-Meghana Mar 25, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(executor): clamp jitter within maxDelayMs to honour delay cap
  • Loading branch information
@Rabba-Meghana
Rabba-Meghana committed Mar 25, 2026
commit d6e45a2b4796ae4b54893741d5b77354f28b7326
2 changes: 1 addition & 1 deletion apps/sim/executor/utils/retry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function calculateBackoffDelay(attempt: number, initialDelayMs: number, maxDelay
const exponential = initialDelayMs * Math.pow(2, attempt)
const capped = Math.min(maxDelayMs, exponential)
const jitter = Math.random() * capped * 0.2
return Math.floor(capped + jitter)
return Math.floor(Math.min(capped + jitter, maxDelayMs))
}
Comment thread
cursor[bot] marked this conversation as resolved.
Copy link
Copy Markdown

@cursor cursor Bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jitter eliminated when backoff delay reaches max cap

Low Severity

In calculateBackoffDelay, capped is already clamped to maxDelayMs, but then jitter is added to capped and the result is clamped again by Math.min(..., maxDelayMs). When exponential >= maxDelayMs, the jitter is always clamped back to zero, producing a deterministic maxDelayMs with no randomization. This defeats the purpose of jitter (preventing thundering herd) once the exponential component reaches the cap. The jitter needs to be subtracted from (or applied within) capped rather than added on top of it.

Fix in Cursor Fix in Web

function parseRetryAfterHeader(headers: Headers): number | null {
Expand Down