Skip to content

fix(blocks): render tooltip field in sub-block label #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minijeong-log wants to merge 2 commits into
base: staging
Choose a base branch
from
+14 −1
Open

fix(blocks): render tooltip field in sub-block label #4073

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2b2206
fix(blocks): render tooltip field in sub-block label
minijeong-log Apr 9, 2026
4891982
fix(blocks): add keyboard accessibility to tooltip triggers
minijeong-log Apr 9, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(blocks): render tooltip field in sub-block label 
Signed-off-by: Mini Jeong <mini.jeong@navercorp.com>
  • Loading branch information
@minijeong-log
minijeong-log committed Apr 9, 2026
commit e2b220614ca534658f03f90934ad401ce565cce3
13 changes: 13 additions & 0 deletions ...eId]/w/[workflowId]/components/panel/components/editor/components/sub-block/sub-block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
Check,
Clipboard,
ExternalLink,
Info,
} from 'lucide-react'
import { useParams } from 'next/navigation'
import { Button, Input, Label, Tooltip } from '@/components/emcn/components'
Expand Down Expand Up @@ -249,6 +250,18 @@ const renderLabel = (
<Label className='flex items-baseline gap-1.5 whitespace-nowrap'>
{config.title}
{required && <span className='ml-0.5'>*</span>}
{config.tooltip && (
<Tooltip.Root>
<Tooltip.Trigger asChild>
<span className='inline-flex'>
<Info className='h-3 w-3 flex-shrink-0 cursor-pointer text-muted-foreground' />
</span>
Comment on lines +255 to +258
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Tooltip trigger not keyboard-accessible

The <span> wrapping the Info icon has no tabIndex, so keyboard-only users cannot focus it to trigger the tooltip. Adding tabIndex={0} (and a matching role) makes it reachable via Tab. Note: the existing AlertTriangle trigger below uses the same pattern, so this affects both.

Suggested change
<Tooltip.Trigger asChild>
<span className='inline-flex'>
<Info className='h-3 w-3 flex-shrink-0 cursor-pointer text-muted-foreground' />
</span>
<span className='inline-flex' tabIndex={0} role='button'>
Copy link
Copy Markdown
Contributor Author

@minijeong-log minijeong-log Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in:

  • e2b2206 — added tabIndex={0} and role='button' to the Info tooltip trigger
  • 4891982 — also applied the same fix to the existing AlertTriangle trigger as noted
</Tooltip.Trigger>
<Tooltip.Content side='top'>
<p>{config.tooltip}</p>
</Tooltip.Content>
</Tooltip.Root>
)}
{labelSuffix}
{config.type === 'code' &&
config.language === 'json' &&
Expand Down