Correct Cloudflare network error detection - #13
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
b3a6ea4 to
1fbad30
Compare
c6b093b to
de6d605
Compare
9e53889 to
38d2ff7
Compare
38d2ff7 to
74dbb3d
Compare
|
This error appears to be Workerd’s generic representation for any The Fetch standard requires network failures to reject with a |
|
Fair enough. I'll post an update here when I open one in |
|
Opened cloudflare/workerd#7195 with a current workerd repro and the Fetch spec requirement: cloudflare/workerd#7195 FWIW - with this realization, you might consider removing the current CF workers check for clarity. Even if |
PR #10 copied Cloudflare's unpunctuated documentation label into the existing
TypeErrormessage set. Workerd instead constructsError("Network connection lost.")for disconnections.This replaces the mistaken matcher with the actual runtime shape and updates the type guard to
Error.Workerd source · Workerd test