Prepare release of 1.1.0#1088
Merged
githubnemo merged 2 commits intomasterfrom Jan 9, 2025
Merged
Conversation
BenjaminBossan
approved these changes
Jan 9, 2025
Collaborator
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks, LGTM, nice find with the deprecated functions. I just have a nit to make the CHANGES.md entries consistent.
|
|
||
| - All neural net classes now inherit from sklearn's [`BaseEstimator`](https://scikit-learn.org/stable/modules/generated/sklearn.base.BaseEstimator.html). This is to support compatibility with sklearn 1.6.0 and above. Classification models additionally inherit from [`ClassifierMixin`](https://scikit-learn.org/stable/modules/generated/sklearn.base.ClassifierMixin.html) and regressors from [`RegressorMixin`](https://scikit-learn.org/stable/modules/generated/sklearn.base.RegressorMixin.html). | ||
| - When using the `ReduceLROnPlateau` learning rate scheduler, we now record the learning rate in the net history (`net.history[:, 'event_lr']` by default). It is now also possible to to step per batch, not only by epoch | ||
| - The learning rate scheduler `.simulate()` method now supports adding step args |
Collaborator
There was a problem hiding this comment.
Could you remove the line breaks to be consistent with the other entries? Also, the other entries are missing the PR reference, could you please add them?
Collaborator
There was a problem hiding this comment.
Thanks. PR is approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the liberty of removing the deprecated
cache_net_infercontext manager. The deprecation time was >1 year.Proposed release text