Release 1.3.0#1124
Merged
BenjaminBossan merged 6 commits intomasterfrom Nov 19, 2025
Merged
Conversation
Since we no longer support torch <= v2.5.0
By now, everyone should have sufficiently recent torch.
For a pandas-related fixture, we had a pytest.mark.skipif decorator. Apparently, that doesn't work and the new pytest now raises an error because of that. Therefore, the decorator is now moved to the class level. While testing this, I noticed that if pandas is not installed, trying to import sacred results in an AttributeError. Therefore, the check whether sacred is installed is now checking for pandas first.
thomasjpfan
approved these changes
Nov 19, 2025
| if pandas_installed: # sacred import fails without pandas | ||
| try: | ||
| # pylint: disable=unused-import | ||
| import sacred |
Member
There was a problem hiding this comment.
sacred was awesome back in the day. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
weights_only=Truetorch.compileavailability, it's been available for long enough@pytest.mark.skipif, this was resolved