Nets now can be loaded even if device=None#876
Merged
BenjaminBossan merged 2 commits intomasterfrom Jul 28, 2022
Merged
Conversation
In #600, we introduced the option to set device=None, which means that skorch should not move any data to any device. However, this setting introduced a bug when trying to load the net, as that code didn't explicitly deal with device=None. With this PR, the bug is fixed. Implementation If device=None, we really have no way of knowing what device to map the parameters to. The most reasonable thing to do is to use the fallback, which is 'cpu'.
Was in "Changed" but should be in "Fixed"
thomasjpfan
reviewed
Jul 28, 2022
Member
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
I am okay with this PR.
Side note: with this fix, models that are pickled with AccelerateMixin and trained on GPU, will fall back to CPU when unpickled. I think that is okay behavior, but not obvious.
Collaborator
Author
@thomasjpfan Yes, absolutely, that's how I discovered the error. I did think about adding a special case for models with an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #600, we introduced the option to set
device=None, which means thatskorch should not move any data to any device. However, this setting
introduced a bug when trying to load the net, as that code didn't
explicitly deal with
device=None.With this PR, the bug is fixed.Implementation
If
device=None, we really have no way of knowing what device to map theparameters to. The most reasonable thing to do is to use the fallback,
which is 'cpu'.