Fix false warning if iterator_valid__shuffle=False#908
Merged
thomasjpfan merged 1 commit intomasterfrom Oct 13, 2022
Merged
Conversation
Resolves #907 The problem initially occurred because the warning did not check for the value, just the presence of the key. Even though there is a test for this, the test didn't detect the error. This is because during a refactor (#751), the parameter validation was moved to initialize() from __init__() but the test was not adjusted to take the change into account.
BenjaminBossan
deleted the
bugfix/false-warning-when-iterator-valid-shuffle-false
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #907
The regression initially occurred because the we did not check for the value of
iterator_valid__shuffle, just the presence of the key.Even though there is a test for this, the test didn't detect the error. This is because during a refactor (#751), the parameter validation was moved to
initialize()from__init__()but the test was not adjusted to take the change into account. For clarity, I moved the test to a separate function (it used to be a subtest of another test).