[WIP] make @compile_fun correctly recurse through imported names, to try to fix #52#53
Open
smarie wants to merge 2 commits into
Open
[WIP] make @compile_fun correctly recurse through imported names, to try to fix #52#53smarie wants to merge 2 commits into
@compile_fun correctly recurse through imported names, to try to fix #52#53smarie wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work in progress: basically
co_namesshould be used (done)But it seems that there are issues with the way the eval dict (globals/locals) is propagated. Indeed when an external symbol is compiled, the eval dict should not be propagated. Instead its own eval dict should be used. This is available through
target.__globals__for functions, but not for other symbols (classes...).Not sure all of this is done correctly today but I actually do not have time to dedicate to it as I am not sure about the potential benefits :)