feat(socket.io): allow passing a Set to to(), in(), and except()#5507
Open
vipin8797 wants to merge 1 commit into
Open
feat(socket.io): allow passing a Set to to(), in(), and except()#5507vipin8797 wants to merge 1 commit into
vipin8797 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
Currently, the
to(),in(), andexcept()methods only acceptRoomorRoom[]. If a developer wants to pass a Set of rooms, they have to manually convert it to an array first (e.g., usingArray.from()).New behavior
The
to(),in(), andexcept()methods now natively acceptSet<Room>in addition toRoomandRoom[]. This is a natural extension of the existing array support.Updated across all entry points:
BroadcastOperator,Namespace,Socket, andServer.I have also added the relevant unit test (
"emits to rooms with a Set") to ensure the functionality works as expected.Other information (e.g. related issues)
Closes #5418