fix createMutable getters do not work if they're on the prototype #1746 #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
|
@ryansolid Updated test, please review. if you remove the changes, then the test will fail |
Member
|
Thank you. This is probably one of those features it would have taken me forever to get around to. |
lilybw
pushed a commit
to lilybw/solid
that referenced
this pull request
Nov 12, 2025
…idjs#1746 (solidjs#2027) * fix createMutable getters do not work if they're on the prototype solidjs#1746 * test update for createMutable getters do not work if they're on the prototype solidjs#1746 * chore remove unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue related: #1746