Skip to content

feat: return 0 when casting an empty string to a number #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2025
Merged

feat: return 0 when casting an empty string to a number #259

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8878b2
feat: return 0 when casting an empty string to a number
sagikazarmark May 31, 2025
2f121f2
refactor: simplify json examples in number tests
sagikazarmark May 31, 2025
b7bd89a
feat: return 0 when casting an empty json.Number to a number
sagikazarmark May 31, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: simplify json examples in number tests 
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
  • Loading branch information
@sagikazarmark
sagikazarmark committed May 31, 2025
commit 2f121f2f536d1e22b1ab92c585ef2adaa01191ff
11 changes: 3 additions & 8 deletions number_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,6 @@ func generateNumberTestCases(samples []any) []testCase {
_ = underflowString
_ = overflowString

var jsonEight, jsonEightNegative, jsonEightPointZero json.Number
_ = json.Unmarshal([]byte("8"), &jsonEight)
_ = json.Unmarshal([]byte("-8"), &jsonEightNegative)
_ = json.Unmarshal([]byte("8.0"), &jsonEightPointZero)

kind := reflect.TypeOf(zero).Kind()
isUint := kind == reflect.Uint || kind == reflect.Uint8 || kind == reflect.Uint16 || kind == reflect.Uint32 || kind == reflect.Uint64

Expand Down Expand Up @@ -219,9 +214,9 @@ func generateNumberTestCases(samples []any) []testCase {
{nil, zero, false},

// JSON
{jsonEight, eight, false},
{jsonEightNegative, eightNegative, isUint},
{jsonEightPointZero, eight, false},
{json.Number("8"), eight, false},
{json.Number("-8"), eightNegative, isUint},
{json.Number("8.0"), eight, false},

// Failure cases
{"test", zero, true},
Expand Down