Skip to content

Test improvements #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 31, 2025
Merged

Test improvements #262

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7093627
test: refactor bool tests
sagikazarmark May 31, 2025
3ea3ef1
test: refactor string tests
sagikazarmark May 31, 2025
3a378b3
refactor: test runner function
sagikazarmark May 31, 2025
3d773c4
refactor: rename test funcs
sagikazarmark May 31, 2025
659da11
feat: add pointer tests
sagikazarmark May 31, 2025
a5c9ee7
test: add pointer tests to numbers
sagikazarmark May 31, 2025
e8b3732
test: improvements
sagikazarmark May 31, 2025
cd8c9c3
refactor: improve time tests
sagikazarmark May 31, 2025
7858930
fix: lint violations
sagikazarmark May 31, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: test runner function 
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
  • Loading branch information
@sagikazarmark
sagikazarmark committed May 31, 2025
commit 3a378b350cb38c564fe9bc79969ddce7dff1c02f
96 changes: 7 additions & 89 deletions basic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,19 @@
// Use of this source code is governed by an MIT-style
// license that can be found in the LICENSE file.

package cast
package cast_test

import (
"encoding/json"
"html/template"
"testing"
"time"

qt "github.com/frankban/quicktest"
"github.com/spf13/cast"
)

func TestToBoolE(t *testing.T) {
testCases := []struct {
input any
expected any
expectError bool
}{
testCases := []testCase{
{0, false, false},
{int(0), false, false},
{int8(0), false, false},
Expand Down Expand Up @@ -86,49 +82,12 @@ func TestToBoolE(t *testing.T) {
{testing.T{}, false, true},
}

for _, testCase := range testCases {
// TODO: remove after minimum Go version is >=1.22
testCase := testCase

t.Run("", func(t *testing.T) {
c := qt.New(t)

{
v := ToBool(testCase.input)
c.Assert(v, qt.Equals, testCase.expected)
}

{
v := To[bool](testCase.input)
c.Assert(v, qt.Equals, testCase.expected)
}

{
v, err := ToBoolE(testCase.input)
if testCase.expectError {
c.Assert(err, qt.IsNotNil)
} else {
c.Assert(err, qt.IsNil)
c.Assert(v, qt.Equals, testCase.expected)
}
}

{
v, err := ToE[bool](testCase.input)
if testCase.expectError {
c.Assert(err, qt.IsNotNil)
} else {
c.Assert(err, qt.IsNil)
c.Assert(v, qt.Equals, testCase.expected)
}
}
})
}
runTests(t, testCases, cast.ToBool, cast.ToBoolE)
}

func BenchmarkToBool(b *testing.B) {
for i := 0; i < b.N; i++ {
if !ToBool(true) {
if !cast.ToBool(true) {
b.Fatal("ToBool returned false")
}
}
Expand All @@ -140,11 +99,7 @@ func TestToStringE(t *testing.T) {
}
key := &Key{"foo"}

testCases := []struct {
input any
expected any
expectError bool
}{
testCases := []testCase{
{int(8), "8", false},
{int8(8), "8", false},
{int16(8), "8", false},
Expand Down Expand Up @@ -177,44 +132,7 @@ func TestToStringE(t *testing.T) {
{key, "", true},
}

for _, testCase := range testCases {
// TODO: remove after minimum Go version is >=1.22
testCase := testCase

t.Run("", func(t *testing.T) {
c := qt.New(t)

{
v := ToString(testCase.input)
c.Assert(v, qt.Equals, testCase.expected)
}

{
v := To[string](testCase.input)
c.Assert(v, qt.Equals, testCase.expected)
}

{
v, err := ToStringE(testCase.input)
if testCase.expectError {
c.Assert(err, qt.IsNotNil)
} else {
c.Assert(err, qt.IsNil)
c.Assert(v, qt.Equals, testCase.expected)
}
}

{
v, err := ToE[string](testCase.input)
if testCase.expectError {
c.Assert(err, qt.IsNotNil)
} else {
c.Assert(err, qt.IsNil)
c.Assert(v, qt.Equals, testCase.expected)
}
}
})
}
runTests(t, testCases, cast.ToString, cast.ToStringE)
}

type foo struct {
Expand Down
48 changes: 48 additions & 0 deletions cast_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,56 @@

package cast_test

import (
"testing"

qt "github.com/frankban/quicktest"
"github.com/spf13/cast"
)

type testCase struct {
input any
expected any
expectError bool
}

func runTests[T cast.Basic](t *testing.T, testCases []testCase, to func(i any) T, toErr func(i any) (T, error)) {
for _, testCase := range testCases {
// TODO: remove after minimum Go version is >=1.22
testCase := testCase

t.Run("", func(t *testing.T) {
c := qt.New(t)

{
v := to(testCase.input)
c.Assert(v, qt.Equals, testCase.expected)
}

{
v := cast.To[T](testCase.input)
c.Assert(v, qt.Equals, testCase.expected)
}

{
v, err := toErr(testCase.input)
if testCase.expectError {
c.Assert(err, qt.IsNotNil)
} else {
c.Assert(err, qt.IsNil)
c.Assert(v, qt.Equals, testCase.expected)
}
}

{
v, err := cast.ToE[T](testCase.input)
if testCase.expectError {
c.Assert(err, qt.IsNotNil)
} else {
c.Assert(err, qt.IsNil)
c.Assert(v, qt.Equals, testCase.expected)
}
}
})
}
}