Skip to content

Conversation

@sagikazarmark
Copy link
Collaborator

No description provided.

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark merged commit 633e5d0 into master Jun 1, 2025
18 checks passed
@andig
Copy link
Contributor

andig commented Jul 9, 2025

@sagikazarmark the downside with this change is that any function ignoring the the error (i.e. without E suffix) will now receive a nil instead of an empty map. That's unexpected compared to older versions and doesn't quite fit the slogan of

safe and easy casting from one type to another in Go

I couldn't determine from the code if you strictly require this change for anything? If not I would propose to always return the empty map instead of nil, as before, as a sane and safe default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants