PR: Add Qt 3D bindings#191
Merged
ccordoba12 merged 2 commits intospyder-ide:masterfrom Jun 12, 2019
Merged
Conversation
Contributor
Author
|
Not everything is installable on CI's, so tests might be skipped. |
ccordoba12
reviewed
Jun 12, 2019
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks a lot for this @jschueller!
I left a minor comment, otherwise it's pretty good.
| import PySide2.Qt3DAnimation as __temp | ||
| import inspect | ||
| for __name in inspect.getmembers(__temp.Qt3DAnimation): | ||
| globals()[__name[0]] = __name[1] |
Member
There was a problem hiding this comment.
This looks very odd, although I understand it's a bug in PySide2. Would you be willing to change it when the bug is fixed upstream?
Contributor
Author
There was a problem hiding this comment.
Yes, of course, I opened the issue so I'll get notified if anything moves upstream.
Member
There was a problem hiding this comment.
Ok, that's all I wanted to know. Thanks!
Member
|
I just released version 1.8.0 with these changes. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #172