PR: Add explicit imports to QtSvg module

[goanpeca]

@ccordoba12, @Nodd should we delete PYQT4, PYQT5, PYSIDE, PythonQtError from the module at the end?

del PYQT4, PYQT5, PYSIDE, PythonQtError ?

[ccordoba12]

should we delete PYQT4, PYQT5, PYSIDE, PythonQtError

I don't think so because they don't belong to the module itself. @Nodd?

[goanpeca]

Ehh ??
precisely because they dont belong and would remain in the namespace is that I am asking if we should delete them.

[ccordoba12]

I really don't see the need of it. That's normally how Python works, i.e. imported symbols remain in the namespace.

[goanpeca]

Yes, I know how it works... this not about how python works or does not, but a user would be able to import PYQT4 from QtCore module and it should not, cause those symbols live in qtpy. not int qtpy.QtCore. We should not encourage that use

[ccordoba12]

I doubt anyone would confuse our constants with proper Qt objects, but I'm neutral about removing or leaving them.

Besides, this needs a rebase now ;-)

[Nodd]

I think that deleting them is indeed cleaner. I don't hink that many users would import it from here, but for example vars(QtSvg) shouldn't show it.

[ccordoba12]

@goanpeca, would you mind to rebase and finish this one so we can merge it?

I agree with @Nodd on removing the PY* constants on every qtpy module :-)

[goanpeca]

ok , will do :-)

[goanpeca]

@ccordoba12, see :-p, its the fastest by far

[ccordoba12]

This looks good to me :-)