[RFC] support build with custom (non-standard) functions#320
Draft
brody4hire wants to merge 1 commit intosql-js:masterfrom
Draft
[RFC] support build with custom (non-standard) functions#320brody4hire wants to merge 1 commit intosql-js:masterfrom
brody4hire wants to merge 1 commit intosql-js:masterfrom
Conversation
brody4hire
force-pushed
the
custom-functions
branch
from
86865e6 to
e316007
Compare
for custom (non-standard) SQLite3 extension functions that may be added in the future with some additional explanatory comments added to the CoffeeScript
brody4hire
force-pushed
the
custom-functions
branch
from
06f6789 to
6a20a45
Compare
brody4hire
referenced
this pull request
in brody4hire/sql.js
Jan 13, 2020
for custom (non-standard) SQLite3 extension functions that may be added in the future with some additional explanatory comments added to the CoffeeScript as proposed in: https://github.com/kripken/sql.js/pull/320
brody4hire
referenced
this pull request
in brody4hire/sql.js
Jan 13, 2020
for custom (non-standard) SQLite3 extension functions that may be added in the future with some additional explanatory comments added to the CoffeeScript as proposed in: https://github.com/kripken/sql.js/pull/320
brody4hire
referenced
this pull request
in brody4hire/sql.js
Jan 13, 2020
for custom (non-standard) SQLite3 extension functions that may be added in the future with some additional explanatory comments added to the CoffeeScript as proposed in: https://github.com/kripken/sql.js/pull/320
This was referenced Feb 18, 2020
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just an idea of how it may be possible to support developers who need to build with non-standard functions. Here is an example where I support UPPER and LOWER functions that can handle many EU characters properly: https://github.com/brodybits/sql.js/tree/custom-eu-string-functions
This idea includes some comments that I think should be considered in
src/api.coffeethat can help make it easier for people like myself to add custom functions in the future.I suspect there should be a much smarter way to do this, by using an array of FuncDef structures like they do in
extension-functions.cfor example.I will very likely continue with the kind of solution proposed here to support the needs of my customer, with hope for a more standardized solution (someday).